build: speed up source tarball creation

richardlau · MylesBorins · commit a4806e2d1298 · 2020-07-27T18:23:47.000-04:00
Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: #34508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
diff --git a/.github/workflows/build-tarball.yml b/.github/workflows/build-tarball.yml
@@ -26,8 +26,8 @@ jobs:
         run: |
           export DISTTYPE=nightly
           export DATESTRING=`date "+%Y-%m-%d"`
-          export COMMIT=xxxx
-          ./configure && make tar -j8
+          export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
+          ./configure && make tar -j8 SKIP_XZ=1
           mkdir tarballs
           mv *.tar.gz tarballs
       - name: Upload tarball artifact
diff --git a/Makefile b/Makefile
@@ -1034,7 +1034,7 @@ pkg-upload: pkg
 	scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
 	ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"
 
-$(TARBALL): release-only $(NODE_EXE) doc
+$(TARBALL): release-only doc-only
 	git checkout-index -a -f --prefix=$(TARNAME)/
 	mkdir -p $(TARNAME)/doc/api
 	cp doc/node.1 $(TARNAME)/doc/node.1
