http2: rename http2_state class to Http2State

danbev · MylesBorins · commit a438d257896f · 2018-05-08T14:22:25.000-07:00
This commit renames the http2_state class to follow the guidelines in CPP_STYLE_GUIDE.md. PR-URL: #20423 Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/env-inl.h b/src/env-inl.h
@@ -482,12 +482,12 @@ inline void Environment::set_http_parser_buffer_in_use(bool in_use) {
   http_parser_buffer_in_use_ = in_use;
 }
 
-inline http2::http2_state* Environment::http2_state() const {
+inline http2::Http2State* Environment::http2_state() const {
   return http2_state_.get();
 }
 
 inline void Environment::set_http2_state(
-    std::unique_ptr<http2::http2_state> buffer) {
+    std::unique_ptr<http2::Http2State> buffer) {
   CHECK(!http2_state_);  // Should be set only once.
   http2_state_ = std::move(buffer);
 }
diff --git a/src/env.h b/src/env.h
@@ -643,8 +643,8 @@ class Environment {
   inline bool http_parser_buffer_in_use() const;
   inline void set_http_parser_buffer_in_use(bool in_use);
 
-  inline http2::http2_state* http2_state() const;
-  inline void set_http2_state(std::unique_ptr<http2::http2_state> state);
+  inline http2::Http2State* http2_state() const;
+  inline void set_http2_state(std::unique_ptr<http2::Http2State> state);
 
   inline AliasedBuffer<double, v8::Float64Array>* fs_stats_field_array();
 
@@ -831,7 +831,7 @@ class Environment {
 
   char* http_parser_buffer_;
   bool http_parser_buffer_in_use_ = false;
-  std::unique_ptr<http2::http2_state> http2_state_;
+  std::unique_ptr<http2::Http2State> http2_state_;
 
   AliasedBuffer<double, v8::Float64Array> fs_stats_field_array_;
 
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -2650,7 +2650,7 @@ void Initialize(Local<Object> target,
   Isolate* isolate = env->isolate();
   HandleScope scope(isolate);
 
-  std::unique_ptr<http2_state> state(new http2_state(isolate));
+  std::unique_ptr<Http2State> state(new Http2State(isolate));
 
 #define SET_STATE_TYPEDARRAY(name, field)             \
   target->Set(context,                                \
diff --git a/src/node_http2_state.h b/src/node_http2_state.h
@@ -84,9 +84,9 @@ namespace http2 {
     IDX_SESSION_STATS_COUNT
   };
 
-class http2_state {
+class Http2State {
  public:
-  explicit http2_state(v8::Isolate* isolate) :
+  explicit Http2State(v8::Isolate* isolate) :
     root_buffer(
       isolate,
       sizeof(http2_state_internal)),

Original file line number	Diff line number	Diff line change
`@@ -482,12 +482,12 @@ inline void Environment::set_http_parser_buffer_in_use(bool in_use) {`
`482`	`482`	`http_parser_buffer_in_use_ = in_use;`
`483`	`483`	`}`
`484`	`484`
`485`		`-inline http2::http2_state* Environment::http2_state() const {`
	`485`	`+inline http2::Http2State* Environment::http2_state() const {`
`486`	`486`	`return http2_state_.get();`
`487`	`487`	`}`
`488`	`488`
`489`	`489`	`inline void Environment::set_http2_state(`
`490`		`- std::unique_ptr<http2::http2_state> buffer) {`
	`490`	`+ std::unique_ptr<http2::Http2State> buffer) {`
`491`	`491`	`CHECK(!http2_state_); // Should be set only once.`
`492`	`492`	`http2_state_ = std::move(buffer);`
`493`	`493`	`}`