napi: supress invalid coverity leak message

mhdawson · MylesBorins · commit 9b36811d8e51 · 2018-04-16T17:45:48.000-04:00
Coverity was complaining that finalizer was being leaked in this method, however it should be freed when the buffer is finalized so I believe the message is invalid. Add the required comments to suppress the warning. Backport-PR-URL: #19447 PR-URL: #12192 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
diff --git a/src/node_api.cc b/src/node_api.cc
@@ -2291,6 +2291,10 @@ napi_status napi_create_external_buffer(napi_env env,
 
   *result = v8impl::JsValueFromV8LocalValue(maybe.ToLocalChecked());
   return GET_RETURN_STATUS();
+  // Tell coverity that 'finalizer' should not be freed when we return
+  // as it will be deleted when the buffer to which it is associated
+  // is finalized.
+  // coverity[leaked_storage]
 }
 
 napi_status napi_create_buffer_copy(napi_env env,

Original file line number	Diff line number	Diff line change
`@@ -2291,6 +2291,10 @@ napi_status napi_create_external_buffer(napi_env env,`
`2291`	`2291`
`2292`	`2292`	`*result = v8impl::JsValueFromV8LocalValue(maybe.ToLocalChecked());`
`2293`	`2293`	`return GET_RETURN_STATUS();`
	`2294`	`+ // Tell coverity that 'finalizer' should not be freed when we return`
	`2295`	`+ // as it will be deleted when the buffer to which it is associated`
	`2296`	`+ // is finalized.`
	`2297`	`+ // coverity[leaked_storage]`
`2294`	`2298`	`}`
`2295`	`2299`
`2296`	`2300`	`napi_status napi_create_buffer_copy(napi_env env,`