test: fix test-internal-util-assertCrypto regex

danbev · addaleax · commit 924b785d509e · 2017-03-05T23:23:46.000+01:00
When building --without-ssl and then running: out/Release/node --expose-internals test/parallel/test-internal-util-assertCrypto.js The following error is displayed: assert.js:420 throw actual; ^ Error: Node.js is not compiled with openssl crypto support at Object.exports.assertCrypto (internal/util.js:82:11) at assert.throws (/Users/danielbevenius/work/nodejs/node/test/parallel/test-internal-util-assertCrypto.js:8:28) at _tryBlock (assert.js:379:5) at _throws (assert.js:398:12) at Function.throws (assert.js:428:3) at Object.<anonymous> (/Users/danielbevenius/work/nodejs/node/test/parallel/test-internal-util-assertCrypto.js:8:10) at Module._compile (module.js:571:32) at Object.Module._extensions..js (module.js:580:10) at Module.load (module.js:488:32) at tryModuleLoad (module.js:447:12) It looks like the regex is not taking into account the 'Error: ' hence the failure to match it. PR-URL: #11620 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-internal-util-assertCrypto.js b/test/parallel/test-internal-util-assertCrypto.js
@@ -6,7 +6,7 @@ const util = require('internal/util');
 
 if (!process.versions.openssl) {
   assert.throws(() => util.assertCrypto(),
-                /^Node.js is not compiled with openssl crypto support$/);
+                /^Error: Node.js is not compiled with openssl crypto support$/);
 } else {
   assert.doesNotThrow(() => util.assertCrypto());
 }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ const util = require('internal/util');`
`6`	`6`
`7`	`7`	`if (!process.versions.openssl) {`
`8`	`8`	`assert.throws(() => util.assertCrypto(),`
`9`		`- /^Node.js is not compiled with openssl crypto support$/);`
	`9`	`+ /^Error: Node.js is not compiled with openssl crypto support$/);`
`10`	`10`	`} else {`
`11`	`11`	`assert.doesNotThrow(() => util.assertCrypto());`
`12`	`12`	`}`