src: use default initializers over settings fields on the constructor

andrewjdmccann · MylesBorins · commit 90cbeae6d987 · 2018-10-30T04:43:13.000-04:00
PR-URL: #23532 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
@@ -50,9 +50,7 @@ using v8::String;
 using v8::Value;
 
 
-SyncProcessOutputBuffer::SyncProcessOutputBuffer()
-    : used_(0),
-      next_(nullptr) {
+SyncProcessOutputBuffer::SyncProcessOutputBuffer() {
 }
 
 
diff --git a/src/spawn_sync.h b/src/spawn_sync.h
@@ -56,9 +56,9 @@ class SyncProcessOutputBuffer {
  private:
   // Use unsigned int because that's what `uv_buf_init` takes.
   mutable char data_[kBufferSize];
-  unsigned int used_;
+  unsigned int used_ = 0;
 
-  SyncProcessOutputBuffer* next_;
+  SyncProcessOutputBuffer* next_ = nullptr;
 };
 
 

Original file line number	Diff line number	Diff line change
`@@ -50,9 +50,7 @@ using v8::String;`
`50`	`50`	`using v8::Value;`
`51`	`51`
`52`	`52`
`53`		`-SyncProcessOutputBuffer::SyncProcessOutputBuffer()`
`54`		`- : used_(0),`
`55`		`- next_(nullptr) {`
	`53`	`+SyncProcessOutputBuffer::SyncProcessOutputBuffer() {`
`56`	`54`	`}`
`57`	`55`
`58`	`56`