src: remove PBKDF2Request::release()

bnoordhuis · addaleax · commit 8f4b84ba4235 · 2017-07-18T19:59:54.000+02:00
PR-URL: #14122 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5245,7 +5245,18 @@ class PBKDF2Request : public AsyncWrap {
   }
 
   ~PBKDF2Request() override {
-    release();
+    free(pass_);
+    pass_ = nullptr;
+    passlen_ = 0;
+
+    free(salt_);
+    salt_ = nullptr;
+    saltlen_ = 0;
+
+    free(key_);
+    key_ = nullptr;
+    keylen_ = 0;
+
     ClearWrap(object());
     persistent().Reset();
   }
@@ -5286,20 +5297,6 @@ class PBKDF2Request : public AsyncWrap {
     return iter_;
   }
 
-  inline void release() {
-    free(pass_);
-    pass_ = nullptr;
-    passlen_ = 0;
-
-    free(salt_);
-    salt_ = nullptr;
-    saltlen_ = 0;
-
-    free(key_);
-    key_ = nullptr;
-    keylen_ = 0;
-  }
-
   inline int error() const {
     return error_;
   }
