fs: allow passing true to emitClose option

gntem · BridgeAR · commit 8f47ff16d484 · 2019-09-03T14:14:11.000+02:00
Allow passing true for emitClose option for fs streams. Fixes: #29177 PR-URL: #29212 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js
@@ -61,7 +61,9 @@ function ReadStream(path, options) {
     options.highWaterMark = 64 * 1024;
 
   // For backwards compat do not emit close on destroy.
-  options.emitClose = false;
+  if (options.emitClose === undefined) {
+    options.emitClose = false;
+  }
 
   Readable.call(this, options);
 
@@ -237,7 +239,9 @@ function WriteStream(path, options) {
   options = copyObject(getOptions(options, {}));
 
   // For backwards compat do not emit close on destroy.
-  options.emitClose = false;
+  if (options.emitClose === undefined) {
+    options.emitClose = false;
+  }
 
   Writable.call(this, options);
 
