util: fix inspecting symbol key in string

barinali · evanlucas · commit 7b8436363684 · 2017-03-07T05:56:56.000-06:00
PR-URL: #11672 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/util.js b/lib/util.js
@@ -396,6 +396,10 @@ function formatValue(ctx, value, recurseTimes) {
     // for boxed Strings, we have to remove the 0-n indexed entries,
     // since they just noisy up the output and are redundant
     keys = keys.filter(function(key) {
+      if (typeof key === 'symbol') {
+        return true;
+      }
+
       return !(key >= 0 && key < raw.length);
     });
   }
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -50,6 +50,9 @@ assert.strictEqual(util.inspect(Object.create({},
   {visible: {value: 1, enumerable: true}, hidden: {value: 2}})),
                    '{ visible: 1 }'
 );
+assert.strictEqual(util.inspect(Object.assign(new String('hello'),
+                   { [Symbol('foo')]: 123 }), { showHidden: true }),
+                   '{ [String: \'hello\'] [length]: 5, [Symbol(foo)]: 123 }');
 
 {
   const regexp = /regexp/;

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ assert.strictEqual(util.inspect(Object.create({},`
`50`	`50`	`{visible: {value: 1, enumerable: true}, hidden: {value: 2}})),`
`51`	`51`	`'{ visible: 1 }'`
`52`	`52`	`);`
	`53`	`+assert.strictEqual(util.inspect(Object.assign(new String('hello'),`
	`54`	`+ { [Symbol('foo')]: 123 }), { showHidden: true }),`
	`55`	`+ '{ [String: \'hello\'] [length]: 5, [Symbol(foo)]: 123 }');`
`53`	`56`
`54`	`57`	`{`
`55`	`58`	`const regexp = /regexp/;`