cli: add --stack-trace-limit to NODE_OPTIONS

addaleax · cjihrig · commit 7349d4294508 · 2017-11-06T17:42:44.000-05:00
I decided that it would make a lot of sense for me to set `NODE_OPTIONS=--stack-trace-limit=100` on my development machine. This code allows me to do that. :) PR-URL: #16495 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -471,6 +471,7 @@ Node options that are allowed are:
 V8 options that are allowed are:
 - `--abort-on-uncaught-exception`
 - `--max-old-space-size`
+- `--stack-trace-limit`
 
 ### `NODE_PENDING_DEPRECATION=1`
 <!-- YAML
diff --git a/src/node.cc b/src/node.cc
@@ -4051,6 +4051,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
     // V8 options (define with '_', which allows '-' or '_')
     "--abort_on_uncaught_exception",
     "--max_old_space_size",
+    "--stack_trace_limit",
   };
 
   for (unsigned i = 0; i < arraysize(whitelist); i++) {
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -33,16 +33,26 @@ if (common.hasCrypto) {
 // V8 options
 expect('--abort_on-uncaught_exception', 'B\n');
 expect('--max-old-space-size=0', 'B\n');
+expect('--stack-trace-limit=100',
+       /(\s*at f \(\[eval\]:1:\d*\)\n){100}/,
+       '(function f() { f(); })();',
+       true);
 
-function expect(opt, want) {
-  const argv = ['-e', 'console.log("B")'];
+function expect(opt, want, command = 'console.log("B")', wantsError = false) {
+  const argv = ['-e', command];
   const opts = {
     env: Object.assign({}, process.env, { NODE_OPTIONS: opt }),
     maxBuffer: 1e6,
   };
-  exec(process.execPath, argv, opts, common.mustCall((err, stdout) => {
-    assert.ifError(err);
-    if (stdout.includes(want)) return;
+  if (typeof want === 'string')
+    want = new RegExp(want);
+  exec(process.execPath, argv, opts, common.mustCall((err, stdout, stderr) => {
+    if (wantsError) {
+      stdout = stderr;
+    } else {
+      assert.ifError(err);
+    }
+    if (want.test(stdout)) return;
 
     const o = JSON.stringify(opt);
     assert.fail(`For ${o}, failed to find ${want} in: <\n${stdout}\n>`);
