src: add string_view overload to snapshot FromBlob

addaleax · marco-ippolito · commit 6af7b78b0df7 · 2024-05-03T08:30:34.000+02:00
The `const std::vector<char>&` variant only delegates to a method that converts it to a `std::string_view` anyway, but adding this capability to the public API as well means that it’s easier to store snapshot data in embedding applications (because using `std::vector<>` enforces heap allocation and `std::string_view` does not). PR-URL: #52595 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/src/api/embed_helpers.cc b/src/api/embed_helpers.cc
@@ -302,6 +302,11 @@ EmbedderSnapshotData::Pointer EmbedderSnapshotData::BuiltinSnapshotData() {
 
 EmbedderSnapshotData::Pointer EmbedderSnapshotData::FromBlob(
     const std::vector<char>& in) {
+  return FromBlob(std::string_view(in.data(), in.size()));
+}
+
+EmbedderSnapshotData::Pointer EmbedderSnapshotData::FromBlob(
+    std::string_view in) {
   SnapshotData* snapshot_data = new SnapshotData();
   CHECK_EQ(snapshot_data->data_ownership, SnapshotData::DataOwnership::kOwned);
   EmbedderSnapshotData::Pointer result{
diff --git a/src/node.h b/src/node.h
@@ -537,6 +537,7 @@ class EmbedderSnapshotData {
   // If the snapshot is invalid, this returns an empty pointer.
   static Pointer FromFile(FILE* in);
   static Pointer FromBlob(const std::vector<char>& in);
+  static Pointer FromBlob(std::string_view in);
 
   // Write this EmbedderSnapshotData object to an output file.
   // Calling this method will not close the FILE* handle.
