n-api: fix memory leak in napi_async_destroy()

alnyan · MylesBorins · commit 65ea7abd55c0 · 2018-04-16T17:46:12.000-04:00
Backport-PR-URL: #19447 PR-URL: #17714 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_api.cc b/src/node_api.cc
@@ -2864,6 +2864,8 @@ napi_status napi_async_destroy(napi_env env,
       reinterpret_cast<node::async_context*>(async_context);
   node::EmitAsyncDestroy(isolate, *node_async_context);
 
+  delete node_async_context;
+
   return napi_clear_last_error(env);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2864,6 +2864,8 @@ napi_status napi_async_destroy(napi_env env,`
`2864`	`2864`	`reinterpret_cast<node::async_context*>(async_context);`
`2865`	`2865`	`node::EmitAsyncDestroy(isolate, *node_async_context);`
`2866`	`2866`
	`2867`	`+ delete node_async_context;`
	`2868`	`+`
`2867`	`2869`	`return napi_clear_last_error(env);`
`2868`	`2870`	`}`
`2869`	`2871`