src: remove unnecessary ToLocalChecked call

danbev · codebytere · commit 5b8cac8cf5a9 · 2020-07-08T18:27:08.000-07:00
PR-URL: #33683 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/src/node_native_module_env.cc b/src/node_native_module_env.cc
@@ -127,8 +127,9 @@ void NativeModuleEnv::CompileFunction(const FunctionCallbackInfo<Value>& args) {
       NativeModuleLoader::GetInstance()->CompileAsModule(
           env->context(), id, &result);
   RecordResult(id, result, env);
-  if (!maybe.IsEmpty()) {
-    args.GetReturnValue().Set(maybe.ToLocalChecked());
+  Local<Function> fn;
+  if (maybe.ToLocal(&fn)) {
+    args.GetReturnValue().Set(fn);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -127,8 +127,9 @@ void NativeModuleEnv::CompileFunction(const FunctionCallbackInfo<Value>& args) {`
`127`	`127`	`NativeModuleLoader::GetInstance()->CompileAsModule(`
`128`	`128`	`env->context(), id, &result);`
`129`	`129`	`RecordResult(id, result, env);`
`130`		`- if (!maybe.IsEmpty()) {`
`131`		`- args.GetReturnValue().Set(maybe.ToLocalChecked());`
	`130`	`+ Local<Function> fn;`
	`131`	`+ if (maybe.ToLocal(&fn)) {`
	`132`	`+ args.GetReturnValue().Set(fn);`
`132`	`133`	`}`
`133`	`134`	`}`
`134`	`135`