fs: validate fd from cpp on fchown

anonrig · marco-ippolito · commit 51d7cd5de839 · 2024-05-03T08:29:51.000+02:00
PR-URL: #52051 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -2028,7 +2028,7 @@ function fchown(fd, uid, gid, callback) {
 
   const req = new FSReqCallback();
   req.oncomplete = callback;
-  binding.fchown(getValidatedFd(fd), uid, gid, req);
+  binding.fchown(fd, uid, gid, req);
 }
 
 /**
@@ -2042,7 +2042,7 @@ function fchownSync(fd, uid, gid) {
   validateInteger(uid, 'uid', -1, kMaxUserId);
   validateInteger(gid, 'gid', -1, kMaxUserId);
 
-  binding.fchown(getValidatedFd(fd), uid, gid);
+  binding.fchown(fd, uid, gid);
 }
 
 /**
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -2695,8 +2695,10 @@ static void FChown(const FunctionCallbackInfo<Value>& args) {
   const int argc = args.Length();
   CHECK_GE(argc, 3);
 
-  CHECK(args[0]->IsInt32());
-  const int fd = args[0].As<Int32>()->Value();
+  int fd;
+  if (!GetValidatedFd(env, args[0]).To(&fd)) {
+    return;
+  }
 
   CHECK(IsSafeJsInt(args[1]));
   const uv_uid_t uid = static_cast<uv_uid_t>(args[1].As<Integer>()->Value());

Original file line number	Diff line number	Diff line change
`@@ -2028,7 +2028,7 @@ function fchown(fd, uid, gid, callback) {`
`2028`	`2028`
`2029`	`2029`	`const req = new FSReqCallback();`
`2030`	`2030`	`req.oncomplete = callback;`
`2031`		`- binding.fchown(getValidatedFd(fd), uid, gid, req);`
	`2031`	`+ binding.fchown(fd, uid, gid, req);`
`2032`	`2032`	`}`
`2033`	`2033`
`2034`	`2034`	`/**`
`@@ -2042,7 +2042,7 @@ function fchownSync(fd, uid, gid) {`
`2042`	`2042`	`validateInteger(uid, 'uid', -1, kMaxUserId);`
`2043`	`2043`	`validateInteger(gid, 'gid', -1, kMaxUserId);`
`2044`	`2044`
`2045`		`- binding.fchown(getValidatedFd(fd), uid, gid);`
	`2045`	`+ binding.fchown(fd, uid, gid);`
`2046`	`2046`	`}`
`2047`	`2047`
`2048`	`2048`	`/**`