lib: replace Symbol.asyncIterator by SymbolAsyncIterator

Sebastien-Ahkrin · BethGriggs · commit 497a1c84054d · 2020-02-06T02:49:23.000Z
PR-URL: #30947 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -27,7 +27,7 @@ const {
   NumberIsNaN,
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
-  Symbol,
+  SymbolAsyncIterator,
 } = primordials;
 
 module.exports = Readable;
@@ -1073,7 +1073,7 @@ Readable.prototype.wrap = function(stream) {
   return this;
 };
 
-Readable.prototype[Symbol.asyncIterator] = function() {
+Readable.prototype[SymbolAsyncIterator] = function() {
   if (createReadableStreamAsyncIterator === undefined) {
     createReadableStreamAsyncIterator =
       require('internal/streams/async_iterator');
diff --git a/lib/internal/fs/dir.js b/lib/internal/fs/dir.js
@@ -3,6 +3,7 @@
 const {
   ObjectDefineProperty,
   Symbol,
+  SymbolAsyncIterator,
 } = primordials;
 
 const pathModule = require('path');
@@ -175,7 +176,7 @@ class Dir {
   }
 }
 
-ObjectDefineProperty(Dir.prototype, Symbol.asyncIterator, {
+ObjectDefineProperty(Dir.prototype, SymbolAsyncIterator, {
   value: Dir.prototype.entries,
   enumerable: false,
   writable: true,
diff --git a/lib/internal/streams/from.js b/lib/internal/streams/from.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const {
-  Symbol,
+  SymbolAsyncIterator,
   SymbolIterator
 } = primordials;
 
@@ -11,8 +11,8 @@ const {
 
 function from(Readable, iterable, opts) {
   let iterator;
-  if (iterable && iterable[Symbol.asyncIterator])
-    iterator = iterable[Symbol.asyncIterator]();
+  if (iterable && iterable[SymbolAsyncIterator])
+    iterator = iterable[SymbolAsyncIterator]();
   else if (iterable && iterable[SymbolIterator])
     iterator = iterable[SymbolIterator]();
   else
diff --git a/lib/readline.js b/lib/readline.js
@@ -37,6 +37,7 @@ const {
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
   Symbol,
+  SymbolAsyncIterator,
 } = primordials;
 
 const {
@@ -1088,7 +1089,7 @@ Interface.prototype._ttyWrite = function(s, key) {
   }
 };
 
-Interface.prototype[Symbol.asyncIterator] = function() {
+Interface.prototype[SymbolAsyncIterator] = function() {
   if (this[kLineObjectStream] === undefined) {
     if (Readable === undefined) {
       Readable = require('stream').Readable;
@@ -1118,7 +1119,7 @@ Interface.prototype[Symbol.asyncIterator] = function() {
     this[kLineObjectStream] = readable;
   }
 
-  return this[kLineObjectStream][Symbol.asyncIterator]();
+  return this[kLineObjectStream][SymbolAsyncIterator]();
 };
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`const {`
`4`	`4`	`ObjectDefineProperty,`
`5`	`5`	`Symbol,`
	`6`	`+ SymbolAsyncIterator,`
`6`	`7`	`} = primordials;`
`7`	`8`
`8`	`9`	`const pathModule = require('path');`
`@@ -175,7 +176,7 @@ class Dir {`
`175`	`176`	`}`
`176`	`177`	`}`
`177`	`178`
`178`		`-ObjectDefineProperty(Dir.prototype, Symbol.asyncIterator, {`
	`179`	`+ObjectDefineProperty(Dir.prototype, SymbolAsyncIterator, {`
`179`	`180`	`value: Dir.prototype.entries,`
`180`	`181`	`enumerable: false,`
`181`	`182`	`writable: true,`