Skip to content

Commit 3f269cc

Browse files
edsadrFishrock123
edsadr
authored and
Fishrock123
committed
test: use ES6 in test-debugger-client.js
implements ES6 const and let instead var in test-debugger-client.js PR-URL: #10183 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 80cccce commit 3f269cc

File tree

1 file changed

+35
-35
lines changed

1 file changed

+35
-35
lines changed

‎test/debugger/test-debugger-client.js‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
'use strict';
22
const common = require('../common');
3-
var assert = require('assert');
4-
var debug = require('_debugger');
3+
const assert = require('assert');
4+
const debug = require('_debugger');
55

66
process.env.NODE_DEBUGGER_TIMEOUT = 2000;
7-
var debugPort = common.PORT;
7+
const debugPort = common.PORT;
88
debug.port = debugPort;
9-
var spawn = require('child_process').spawn;
9+
const spawn = require('child_process').spawn;
1010

1111
setTimeout(function() {
1212
if (nodeProcess) nodeProcess.kill('SIGTERM');
1313
throw new Error('timeout');
1414
}, 10000).unref();
1515

1616

17-
var resCount = 0;
18-
var p = new debug.Protocol();
17+
let resCount = 0;
18+
const p = new debug.Protocol();
1919
p.onResponse = function(res) {
2020
resCount++;
2121
};
@@ -29,12 +29,12 @@ assert.strictEqual(resCount, 1);
2929

3030
// Make sure split messages go in.
3131

32-
var parts = [];
32+
const parts = [];
3333
parts.push('Content-Length: 336\r\n');
3434
assert.strictEqual(parts[0].length, 21);
3535
parts.push('\r\n');
3636
assert.strictEqual(parts[1].length, 2);
37-
var bodyLength = 0;
37+
let bodyLength = 0;
3838

3939
parts.push('{"seq":12,"type":"event","event":"break","body":' +
4040
'{"invocationText":"#<a Server>');
@@ -55,32 +55,32 @@ bodyLength += parts[4].length;
5555

5656
assert.strictEqual(bodyLength, 336);
5757

58-
for (var i = 0; i < parts.length; i++) {
58+
for (let i = 0; i < parts.length; i++) {
5959
p.execute(parts[i]);
6060
}
6161
assert.strictEqual(resCount, 2);
6262

6363

6464
// Make sure that if we get backed up, we still manage to get all the
6565
// messages
66-
var d = 'Content-Length: 466\r\n\r\n' +
67-
'{"seq":10,"type":"event","event":"afterCompile","success":true,' +
68-
'"body":{"script":{"handle":1,"type":"script","name":"dns.js",' +
69-
'"id":34,"lineOffset":0,"columnOffset":0,"lineCount":241,' +
70-
'"sourceStart":"(function(module, exports, require) {' +
71-
'var dns = process.binding(\'cares\')' +
72-
';\\nvar ne","sourceLength":6137,"scriptType":2,"compilationType":0,' +
73-
'"context":{"ref":0},"text":"dns.js (lines: 241)"}},"refs":' +
74-
'[{"handle":0' +
75-
',"type":"context","text":"#<a ContextMirror>"}],"running":true}' +
76-
'\r\n\r\nContent-Length: 119\r\n\r\n' +
77-
'{"seq":11,"type":"event","event":"scriptCollected","success":true,' +
78-
'"body":{"script":{"id":26}},"refs":[],"running":true}';
66+
const d = 'Content-Length: 466\r\n\r\n' +
67+
'{"seq":10,"type":"event","event":"afterCompile","success":true,' +
68+
'"body":{"script":{"handle":1,"type":"script","name":"dns.js",' +
69+
'"id":34,"lineOffset":0,"columnOffset":0,"lineCount":241,' +
70+
'"sourceStart":"(function(module, exports, require) {' +
71+
'var dns = process.binding(\'cares\')' +
72+
';\\nvar ne","sourceLength":6137,"scriptType":2,"compilationType"' +
73+
':0,"context":{"ref":0},"text":"dns.js (lines: 241)"}},"refs":' +
74+
'[{"handle":0' +
75+
',"type":"context","text":"#<a ContextMirror>"}],"running":true}' +
76+
'\r\n\r\nContent-Length: 119\r\n\r\n' +
77+
'{"seq":11,"type":"event","event":"scriptCollected","success":true' +
78+
',"body":{"script":{"id":26}},"refs":[],"running":true}';
7979
p.execute(d);
8080
assert.strictEqual(resCount, 4);
8181

82-
var expectedConnections = 0;
83-
var tests = [];
82+
let expectedConnections = 0;
83+
const tests = [];
8484
function addTest(cb) {
8585
expectedConnections++;
8686
tests.push(cb);
@@ -102,9 +102,9 @@ addTest(function(client, done) {
102102
assert.ok(!err);
103103
console.error('got %d scripts', Object.keys(client.scripts).length);
104104

105-
var foundMainScript = false;
106-
for (var k in client.scripts) {
107-
var script = client.scripts[k];
105+
let foundMainScript = false;
106+
for (const k in client.scripts) {
107+
const script = client.scripts[k];
108108
if (script && script.name === 'node.js') {
109109
foundMainScript = true;
110110
break;
@@ -127,19 +127,19 @@ addTest(function(client, done) {
127127
});
128128

129129

130-
var connectCount = 0;
131-
var script = 'setTimeout(function() { console.log("blah"); });' +
132-
'setInterval(function() {}, 1000000);';
130+
let connectCount = 0;
131+
const script = 'setTimeout(function() { console.log("blah"); });' +
132+
'setInterval(function() {}, 1000000);';
133133

134-
var nodeProcess;
134+
let nodeProcess;
135135

136136
function doTest(cb, done) {
137-
var args = ['--debug=' + debugPort, '-e', script];
137+
const args = ['--debug=' + debugPort, '-e', script];
138138
nodeProcess = spawn(process.execPath, args);
139139

140140
nodeProcess.stdout.once('data', function(c) {
141141
console.log('>>> new node process: %d', nodeProcess.pid);
142-
var failed = true;
142+
let failed = true;
143143
try {
144144
process._debugProcess(nodeProcess.pid);
145145
failed = false;
@@ -151,9 +151,9 @@ function doTest(cb, done) {
151151
console.log('>>> starting debugger session');
152152
});
153153

154-
var didTryConnect = false;
154+
let didTryConnect = false;
155155
nodeProcess.stderr.setEncoding('utf8');
156-
var b = '';
156+
let b = '';
157157
nodeProcess.stderr.on('data', function(data) {
158158
console.error('got stderr data %j', data);
159159
nodeProcess.stderr.resume();

0 commit comments

Comments
 (0)