test: use common.fixturesDir almost everywhere

bengl · MylesBorins · commit 324c82b1c97a · 2017-01-31T20:04:31.000-05:00
Updating tests to use `common.fixturesDir` whenever possible/reasonable. Left out things like tests for `path` and `require.resolve`. PR-URL: #6997 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-child-process-detached.js b/test/parallel/test-child-process-detached.js
@@ -1,10 +1,10 @@
 'use strict';
-require('../common');
+var common = require('../common');
 var assert = require('assert');
 var path = require('path');
 
 var spawn = require('child_process').spawn;
-var childPath = path.join(__dirname, '..', 'fixtures',
+var childPath = path.join(common.fixturesDir,
                           'parent-process-nonpersistent.js');
 var persistentPid = -1;
 
diff --git a/test/parallel/test-delayed-require.js b/test/parallel/test-delayed-require.js
@@ -1,9 +1,10 @@
 'use strict';
-const common = require('../common');
+var common = require('../common');
+var path = require('path');
 var assert = require('assert');
 
 setTimeout(common.mustCall(function() {
-  const a = require('../fixtures/a');
+  const a = require(path.join(common.fixturesDir, 'a'));
   assert.strictEqual(true, 'A' in a);
   assert.strictEqual('A', a.A());
   assert.strictEqual('D', a.D());
diff --git a/test/parallel/test-global.js b/test/parallel/test-global.js
@@ -1,5 +1,6 @@
 /* eslint-disable strict */
 var common = require('../common');
+var path = require('path');
 var assert = require('assert');
 
 common.globalCheck = false;
@@ -13,7 +14,7 @@ assert.equal('bar',
              baseBar, // eslint-disable-line no-undef
              'global.x -> x in base level not working');
 
-var module = require('../fixtures/global/plain');
+var module = require(path.join(common.fixturesDir, 'global', 'plain'));
 const fooBar = module.fooBar;
 
 assert.equal('foo', fooBar.foo, 'x -> global.x in sub level not working');
diff --git a/test/parallel/test-http-default-port.js b/test/parallel/test-http-default-port.js
@@ -5,7 +5,7 @@ const assert = require('assert');
 const hostExpect = 'localhost';
 const fs = require('fs');
 const path = require('path');
-const fixtures = path.resolve(__dirname, '../fixtures/keys');
+const fixtures = path.join(common.fixturesDir, 'keys');
 const options = {
   key: fs.readFileSync(fixtures + '/agent1-key.pem'),
   cert: fs.readFileSync(fixtures + '/agent1-cert.pem')
diff --git a/test/parallel/test-internal-modules.js b/test/parallel/test-internal-modules.js
@@ -1,9 +1,10 @@
 'use strict';
-require('../common');
+var common = require('../common');
+var path = require('path');
 var assert = require('assert');
 
 assert.throws(function() {
   require('internal/freelist');
 });
 
-assert(require('../fixtures/internal-modules') === 42);
+assert(require(path.join(common.fixturesDir, 'internal-modules')) === 42);
diff --git a/test/parallel/test-preload.js b/test/parallel/test-preload.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const path = require('path');
 const child_process = require('child_process');
@@ -15,7 +15,7 @@ var preloadOption = function(preloads) {
 };
 
 var fixture = function(name) {
-  return path.join(__dirname, '../fixtures/' + name);
+  return path.join(common.fixturesDir, name);
 };
 
 var fixtureA = fixture('printA.js');
@@ -82,7 +82,7 @@ child_process.exec(nodeBinary + ' '
   });
 
 // https://github.com/nodejs/node/issues/1691
-process.chdir(path.join(__dirname, '../fixtures/'));
+process.chdir(common.fixturesDir);
 child_process.exec(nodeBinary + ' '
   + '--expose_debug_as=v8debug '
   + '--require ' + fixture('cluster-preload.js') + ' '
diff --git a/test/parallel/test-repl-persistent-history.js b/test/parallel/test-repl-persistent-history.js
@@ -68,7 +68,7 @@ const sameHistoryFilePaths = '\nThe old repl history file has the same name ' +
                              path.join(common.tmpDir, '.node_repl_history') +
                              ' and is empty.\nUsing it as is.\n';
 // File paths
-const fixtures = path.join(common.testDir, 'fixtures');
+const fixtures = common.fixturesDir;
 const historyFixturePath = path.join(fixtures, '.node_repl_history');
 const historyPath = path.join(common.tmpDir, '.fixture_copy_repl_history');
 const historyPathFail = path.join(common.tmpDir, '.node_repl\u0000_history');
diff --git a/test/parallel/test-repl-syntax-error-stack.js b/test/parallel/test-repl-syntax-error-stack.js
@@ -17,7 +17,7 @@ common.ArrayStream.prototype.write = function(output) {
 
 const putIn = new common.ArrayStream();
 repl.start('', putIn);
-let file = path.resolve(__dirname, '../fixtures/syntax/bad_syntax');
+let file = path.join(common.fixturesDir, 'syntax', 'bad_syntax');
 
 if (common.isWindows)
   file = file.replace(/\\/g, '\\\\');
diff --git a/test/parallel/test-require-json.js b/test/parallel/test-require-json.js
@@ -1,9 +1,10 @@
 'use strict';
-require('../common');
+var common = require('../common');
+var path = require('path');
 var assert = require('assert');
 
 try {
-  require('../fixtures/invalid.json');
+  require(path.join(common.fixturesDir, 'invalid.json'));
 } catch (err) {
   var re = /test[\/\\]fixtures[\/\\]invalid.json: Unexpected string/;
   var i = err.message.match(re);
diff --git a/test/parallel/test-sync-fileread.js b/test/parallel/test-sync-fileread.js
@@ -1,9 +1,9 @@
 'use strict';
-require('../common');
+var common = require('../common');
 var assert = require('assert');
 var path = require('path');
 var fs = require('fs');
 
-var fixture = path.join(__dirname, '../fixtures/x.txt');
+var fixture = path.join(common.fixturesDir, 'x.txt');
 
 assert.equal('xyz\n', fs.readFileSync(fixture));
diff --git a/test/parallel/test-tls-connect-stream-writes.js b/test/parallel/test-tls-connect-stream-writes.js
@@ -1,14 +1,13 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const fs = require('fs');
-const path = require('path');
 const tls = require('tls');
 const stream = require('stream');
 const net = require('net');
 
 var server;
-var cert_dir = path.resolve(__dirname, '../fixtures');
+var cert_dir = common.fixturesDir;
 var options = { key: fs.readFileSync(cert_dir + '/test_key.pem'),
                 cert: fs.readFileSync(cert_dir + '/test_cert.pem'),
                 ca: [ fs.readFileSync(cert_dir + '/test_ca.pem') ],
diff --git a/test/parallel/test-util-internal.js b/test/parallel/test-util-internal.js
@@ -1,7 +1,8 @@
 'use strict';
 // Flags: --expose_internals
 
-require('../common');
+const common = require('../common');
+const path = require('path');
 const assert = require('assert');
 const internalUtil = require('internal/util');
 
@@ -24,7 +25,7 @@ assert.deepEqual(internalUtil.getHiddenValue({}, 'foo'), undefined);
 let arrowMessage;
 
 try {
-  require('../fixtures/syntax/bad_syntax');
+  require(path.join(common.fixturesDir, 'syntax', 'bad_syntax'));
 } catch (err) {
   arrowMessage = internalUtil.getHiddenValue(err, 'arrowMessage');
 }
diff --git a/test/sequential/test-deprecation-flags.js b/test/sequential/test-deprecation-flags.js
@@ -1,12 +1,12 @@
 'use strict';
-require('../common');
+var common = require('../common');
 var assert = require('assert');
 var execFile = require('child_process').execFile;
 var depmod = require.resolve('../fixtures/deprecated.js');
 var node = process.execPath;
 
 var depUserland =
-    require.resolve('../fixtures/deprecated-userland-function.js');
+    require.resolve(common.fixturesDir + '/deprecated-userland-function.js');
 
 var normal = [depmod];
 var noDep = ['--no-deprecation', depmod];
