test: put expected assert value in correct place

jfarseneau-wb · MylesBorins · commit 23d6932c6146 · 2018-10-30T04:43:10.000-04:00
The order of arguments in test-fs-readdir-ucs2 was the opposite of what is recommended in the documentation, which is that the first value should be the value being tested, and the second value is the expected value. This fixes the test to make it conform to the documentation. PR-URL: #23505 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/parallel/test-fs-readdir-ucs2.js b/test/parallel/test-fs-readdir-ucs2.js
@@ -25,8 +25,8 @@ try {
 
 fs.readdir(tmpdir.path, 'ucs2', common.mustCall((err, list) => {
   assert.ifError(err);
-  assert.strictEqual(1, list.length);
+  assert.strictEqual(list.length, 1);
   const fn = list[0];
-  assert.deepStrictEqual(filebuff, Buffer.from(fn, 'ucs2'));
+  assert.deepStrictEqual(Buffer.from(fn, 'ucs2'), filebuff);
   assert.strictEqual(fn, filename);
 }));
