test: add coverage for napi_has_named_property

mhdawson · MylesBorins · commit 1829d259079b · 2018-04-16T17:45:56.000-04:00
Add test to cover napi_has_named_property Backport-PR-URL: #19447 PR-URL: #13178 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
diff --git a/test/addons-napi/test_properties/test.js b/test/addons-napi/test_properties/test.js
@@ -39,3 +39,9 @@ test_object.readwriteAccessor2 = 2;
 assert.strictEqual(test_object.readwriteAccessor2, 2);
 assert.strictEqual(test_object.readonlyAccessor2, 2);
 assert.throws(() => { test_object.readonlyAccessor2 = 3; }, TypeError);
+
+assert.strictEqual(test_object.hasNamedProperty(test_object, 'echo'), true);
+assert.strictEqual(test_object.hasNamedProperty(test_object, 'hiddenValue'),
+                   true);
+assert.strictEqual(test_object.hasNamedProperty(test_object, 'doesnotexist'),
+                   false);
diff --git a/test/addons-napi/test_properties/test_properties.c b/test/addons-napi/test_properties/test_properties.c
@@ -37,6 +37,28 @@ napi_value Echo(napi_env env, napi_callback_info info) {
   return args[0];
 }
 
+napi_value HasNamedProperty(napi_env env, napi_callback_info info) {
+  size_t argc = 2;
+  napi_value args[2];
+  NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
+
+  NAPI_ASSERT(env, argc == 2, "Wrong number of arguments");
+
+  // Extract the name of the property to check
+  char buffer[128];
+  size_t copied;
+  NAPI_CALL(env,
+    napi_get_value_string_utf8(env, args[1], buffer, sizeof(buffer), &copied));
+
+  // do the check and create the boolean return value
+  bool value;
+  napi_value result;
+  NAPI_CALL(env, napi_has_named_property(env, args[0], buffer, &value));
+  NAPI_CALL(env, napi_get_boolean(env, value, &result));
+
+  return result;
+}
+
 void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
   napi_value number;
   NAPI_CALL_RETURN_VOID(env, napi_create_number(env, value_, &number));
@@ -50,6 +72,7 @@ void Init(napi_env env, napi_value exports, napi_value module, void* priv) {
     { "readwriteAccessor2", 0, 0, GetValue, SetValue, 0, napi_writable, 0},
     { "readonlyAccessor1", 0, 0, GetValue, NULL, 0, napi_default, 0},
     { "readonlyAccessor2", 0, 0, GetValue, NULL, 0, napi_writable, 0},
+    { "hasNamedProperty", 0, HasNamedProperty, 0, 0, 0, napi_default, 0 },
   };
 
   NAPI_CALL_RETURN_VOID(env, napi_define_properties(
