test: improve flakiness detection on stack corruption tests

RaisinTen · aduh95 · commit 0f6a2627448c · 2025-06-10T15:43:21.000+02:00
This change skips asserting the exit code of the child process with the corrupted async hooks stack only on those platforms where termination via a signal has been observed. Refs: #58478 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58601 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/async-hooks/test-emit-after-on-destroyed.js b/test/async-hooks/test-emit-after-on-destroyed.js
@@ -53,9 +53,12 @@ if (process.argv[2] === 'child') {
   child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });
 
   child.on('close', common.mustCall((code, signal) => {
-    if (signal) {
-      console.log(`Child closed with signal: ${signal}`);
+    if ((common.isAIX ||
+         (common.isLinux && process.arch === 'x64')) &&
+         signal === 'SIGABRT') {
+      // XXX: The child process could be aborted due to unknown reasons. Work around it.
     } else {
+      assert.strictEqual(signal, null);
       assert.strictEqual(code, 1);
     }
     assert.match(outData.toString(), heartbeatMsg,
diff --git a/test/async-hooks/test-improper-unwind.js b/test/async-hooks/test-improper-unwind.js
@@ -56,9 +56,12 @@ if (process.argv[2] === 'child') {
   child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); });
 
   child.on('close', common.mustCall((code, signal) => {
-    if (signal) {
-      console.log(`Child closed with signal: ${signal}`);
+    if ((common.isAIX ||
+         (common.isLinux && process.arch === 'x64')) &&
+         signal === 'SIGABRT') {
+      // XXX: The child process could be aborted due to unknown reasons. Work around it.
     } else {
+      assert.strictEqual(signal, null);
       assert.strictEqual(code, 1);
     }
     assert.match(outData.toString(), heartbeatMsg,
