Skip to content

Commit 0e1891a

Browse files
joyeecheungaduh95
authored andcommitted
build: set V8_DISABLE_PRESERVE_MOST
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8532546 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #67093 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1 parent 0c0d3ee commit 0e1891a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

‎common.gypi‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -588,6 +588,13 @@
588588
'_HAS_EXCEPTIONS=0',
589589
'BUILDING_V8_SHARED=1',
590590
'BUILDING_UV_SHARED=1',
591+
# Node.js is built with clang-cl but native addons may be built
592+
# with MSVC, which does not support preserve_most.
593+
# As preserve_most changes the mangled name of a function in the
594+
# Microsoft C++ ABI, the addons would fail to link against the
595+
# exported symbols. So this define must be consistely set for
596+
# both the V8 build and addon builds.
597+
'V8_DISABLE_PRESERVE_MOST',
591598
# Stop <windows.h> from defining macros that conflict with
592599
# std::min() and std::max(). We don't use <windows.h> (much)
593600
# but we still inherit it from uv.h.

0 commit comments

Comments
 (0)