Skip to content

Conversation

@mmarchini
Copy link
Contributor

No description provided.

@mmarchini
Copy link
Contributor Author

cc @nodejs/llnode @nodejs/diagnostics

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmarchini added a commit that referenced this pull request Mar 27, 2020
PR-URL: #349
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mmarchini
Copy link
Contributor Author

Landed in 1839dc3

@mmarchini mmarchini closed this Mar 27, 2020
@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 4e4d874ffc5c49789a21e4fb63fe40ed676037b3-PR-349

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 216 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+4.6%) to 78.64%

Files with Coverage Reduction New Missed Lines %
src/constants.cc 1 80.3%
src/error.h 1 87.5%
src/llv8-constants.cc 2 85.2%
src/llv8.cc 3 71.04%
src/llnode_api.cc 8 87.5%
test/common.js 9 79.24%
src/node-inl.h 11 0.0%
src/node.h 12 20.0%
test/plugin/workqueue-test.js 13 55.17%
src/node.cc 21 37.5%
Totals Coverage Status
Change from base Build 991c731deb4228754e727c908f321e616c60c5dd: 4.6%
Covered Lines: 3714
Relevant Lines: 4710

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants