test: update Error.stack test for V8 7.5 #327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 7.5 changed how it caches the stringified stack on Error objects after the first access. Instead of replacing the accessor Error.stack with the stringified stack, the stringified stack is stored in the same Symbol which was used to store the FrameArray stack. Ref: v8/v8@c820604
mmarchini
added
the
author ready
cjihrig
approved these changes
Dec 10, 2019
mmarchini
added a commit
that referenced
this pull request
Jan 2, 2020
V8 7.5 changed how it caches the stringified stack on Error objects after the first access. Instead of replacing the accessor Error.stack with the stringified stack, the stringified stack is stored in the same Symbol which was used to store the FrameArray stack. Ref: v8/v8@c820604 PR-URL: #327 Refs: v8/v8@c820604 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in f7f9347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 7.5 changed how it caches the stringified stack on Error objects
after the first access. Instead of replacing the accessor Error.stack
with the stringified stack, the stringified stack is stored in the same
Symbol which was used to store the FrameArray stack.
Ref: v8/v8@c820604