build: allow custom lldb headers path with npm install #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to set a custom lldb headers path if configuring the build manually. This commit also allows users to do it when using `npm install`. This is useful when using lldb built from source, for example.
richardlau
approved these changes
Oct 7, 2019
cjihrig
approved these changes
Oct 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=========================================
- Coverage 79.21% 78.4% -0.82%
=========================================
Files 33 33
Lines 4225 4246 +21
=========================================
- Hits 3347 3329 -18
- Misses 878 917 +39
Continue to review full report at Codecov.
|
mmarchini
added a commit
that referenced
this pull request
Jan 2, 2020
It's possible to set a custom lldb headers path if configuring the build manually. This commit also allows users to do it when using `npm install`. This is useful when using lldb built from source, for example. PR-URL: #315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in 9a58d8c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to set a custom lldb headers path if configuring the build
manually. This commit also allows users to do it when using
npm install. This is useful when using lldb built from source, forexample.