src: fix String::Length for Node.js v12.3.0 #302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type of String::Length changed from SMI to int32. This commit changes String::Length to use the new type. String::Length now returns a CheckedType, and places calling String::Length will check the type using .Check instead of Error::Fail, making the code more resilient in case the String length can't be loaded properly.
mmarchini
force-pushed
the
fix-string-len-node12
branch
from
d2fa4cc to
a3c7f2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
+ Coverage 78.6% 79% +0.4%
=======================================
Files 33 33
Lines 4225 4244 +19
=======================================
+ Hits 3321 3353 +32
+ Misses 904 891 -13
Continue to review full report at Codecov.
|
Contributor
Author
|
For posterity, the SMI to int32 change happened here: https://chromium-review.googlesource.com/c/v8/v8/+/1224432/ I'm not sure this pull request fixes all the problems though. I'm still seeing a lot of frames not loading with |
Contributor
Author
|
cc @nodejs/llnode |
cjihrig
approved these changes
Oct 7, 2019
mmarchini
added a commit
that referenced
this pull request
Oct 7, 2019
Type of String::Length changed from SMI to int32. This commit changes String::Length to use the new type. String::Length now returns a CheckedType, and places calling String::Length will check the type using .Check instead of Error::Fail, making the code more resilient in case the String length can't be loaded properly. PR-URL: #302 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in a79a008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of String::Length changed from SMI to int32. This commit changes
String::Length to use the new type. String::Length now returns a
CheckedType, and places calling String::Length will check the type using
.Check instead of Error::Fail, making the code more resilient in case
the String length can't be loaded properly.