Skip to content

src: fix object inspection for V8 6.4 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmarchini merged 2 commits into from
May 15, 2018
Merged

src: fix object inspection for V8 6.4 #192

mmarchini merged 2 commits into from
May 15, 2018

Conversation

@mmarchini
Copy link
Contributor

@mmarchini mmarchini commented May 3, 2018

V8 6.4 "replaces the in-object properties count byte in the map
with the byte that stores the start offset of in-object properties".
Object inspection on llnode relies on in-object properties being count
bytes, so these are minimal changes to make object inspection work again
with V8 6.4 while keeping compatibility with previous versions.

Ref: https://chromium-review.googlesource.com/c/v8/v8/+/776720
Fixes: #158

src: fix object inspection for V8 6.4
f8c118b 
V8 6.4 "replaces the in-object properties count byte in the map
with the byte that stores the start offset of in-object properties".
Object inspection on llnode relies on in-object properties being count
bytes, so these are minimal changes to make object inspection work again
with V8 6.4 while keeping compatibility with previous versions.

Ref: https://chromium-review.googlesource.com/c/v8/v8/+/776720
Fixes: nodejs#158
bnoordhuis

This comment was marked as off-topic.

Sign in to view

@mmarchini
Copy link
Contributor Author

mmarchini commented May 4, 2018

I thought it only applies when the map's instance type >= FIRST_JS_OBJECT_TYPE, i.e., when it's a map describing a JSObject.

There are 5 calls to InObjectProperties in llnode, 4 of them are in JSObject methods, so those calls should be safe. The only one I'm not 100% sure is correct is the call in Map::Inspect. We might need to do some special handling there, but I'm not sure. I'll leave a FIXME comment to investigate this in a follow-up PR, WDYT?

@mmarchini
Copy link
Contributor Author

mmarchini commented May 4, 2018

Improved legibility on InObjectProperty and handled the case where Map don't describe a JSObject. @bnoordhuis PTAL.

Would be nice to have a test for this case. I'll see if I can come up with one later, but suggestions are appreciated 😄

cjihrig

This comment was marked as off-topic.

Sign in to view

cjihrig

This comment was marked as off-topic.

Sign in to view

@mmarchini mmarchini merged commit 7f1e791 into nodejs:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

+1 more reviewer

@cjihrig cjihrig cjihrig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmarchini @bnoordhuis @cjihrig