Handle <adaptor> frames correctly on Node.js v12 #306
Description
On Node.js v12.3 (with #302 and #301 and some other changes I'll submit tomorrow):
frame #7: 0x00000000019f35c4 crasher at /home/mmarchini/workspace/nodejs/llnode/test/fixtures/frame-scenario.js:4:17 fn=0x000016460dac10a1
frame #8: 0x00000000019f35c4 <adaptor>
frame #9: 0x00000000019f35c4 <adaptor>
It should be:
frame #7: 0x000028ce7480e458 crasher at /home/mmarchini/workspace/nodejs/llnode/test/fixtures/frame-scenario.js:4:17 fn=0x00002b44187bfb79
frame #8: 0x000028ce748076a6 <adaptor>
frame #9: 0x000028ce7480e458 eyecatcher at /home/mmarchini/workspace/nodejs/llnode/test/fixtures/frame-scenario.js:22:20 fn=0x00002b44187bfbb9
This is happening because FP is the same for frame 9 and frame 8. I think this is due to this commit: https://chromium-review.googlesource.com/c/v8/v8/+/1488751
From a quick skim, this PR seems to make the frame behave like -fomit-frame-pointer. If that's the case, I would expect The <adaptor> frame to be hidden, but maybe LLDB is guessing it should be loaded because the builtin is now embeded on the binary...
I'm not sure, will need to investigate more later. Opening the issue to share what I found so far.