src: update RegExp type constant for V8 8.1

mmarchini · mmarchini · commit c86eb4356cf1 · 2020-04-27T12:28:51.000-07:00
PR-URL: #361 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/llv8-constants.cc b/src/llv8-constants.cc
@@ -619,7 +619,8 @@ void Types::Load() {
   kFixedArrayType = LoadConstant("type_FixedArray__FIXED_ARRAY_TYPE");
   kJSArrayBufferType = LoadConstant("type_JSArrayBuffer__JS_ARRAY_BUFFER_TYPE");
   kJSTypedArrayType = LoadConstant("type_JSTypedArray__JS_TYPED_ARRAY_TYPE");
-  kJSRegExpType = LoadConstant("type_JSRegExp__JS_REGEXP_TYPE");
+  kJSRegExpType = LoadConstant(
+      {"type_JSRegExp__JS_REG_EXP_TYPE", "type_JSRegExp__JS_REGEXP_TYPE"});
   kJSDateType = LoadConstant("type_JSDate__JS_DATE_TYPE");
   kSharedFunctionInfoType =
       LoadConstant("type_SharedFunctionInfo__SHARED_FUNCTION_INFO_TYPE");
diff --git a/src/llv8-constants.h b/src/llv8-constants.h
@@ -545,7 +545,7 @@ class Types : public Module {
   int64_t kFixedArrayType;
   int64_t kJSArrayBufferType;
   int64_t kJSTypedArrayType;
-  int64_t kJSRegExpType;
+  Constant<int64_t> kJSRegExpType;
   int64_t kJSDateType;
   int64_t kSharedFunctionInfoType;
   Constant<int64_t> kUncompiledDataWithoutPreParsedScopeType;
diff --git a/src/llv8.cc b/src/llv8.cc
@@ -660,7 +660,7 @@ std::string HeapObject::GetTypeName(Error& err) {
     return "(Function)";
   }
 
-  if (type == v8()->types()->kJSRegExpType) {
+  if (type == *v8()->types()->kJSRegExpType) {
     return "(RegExp)";
   }
 
diff --git a/src/printer.cc b/src/printer.cc
@@ -726,7 +726,7 @@ std::string Printer::Stringify(v8::HeapObject heap_object, Error& err) {
     return pre + Stringify(fn, err);
   }
 
-  if (type == llv8_->types()->kJSRegExpType) {
+  if (type == *llv8_->types()->kJSRegExpType) {
     v8::JSRegExp re(heap_object);
     return pre + Stringify(re, err);
   }

Original file line number	Diff line number	Diff line change
`@@ -660,7 +660,7 @@ std::string HeapObject::GetTypeName(Error& err) {`
`660`	`660`	`return "(Function)";`
`661`	`661`	`}`
`662`	`662`
`663`		`- if (type == v8()->types()->kJSRegExpType) {`
	`663`	`+ if (type == *v8()->types()->kJSRegExpType) {`
`664`	`664`	`return "(RegExp)";`
`665`	`665`	`}`
`666`	`666`
Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,7 @@ std::string Printer::Stringify(v8::HeapObject heap_object, Error& err) {`
`726`	`726`	`return pre + Stringify(fn, err);`
`727`	`727`	`}`
`728`	`728`
`729`		`- if (type == llv8_->types()->kJSRegExpType) {`
	`729`	`+ if (type == *llv8_->types()->kJSRegExpType) {`
`730`	`730`	`v8::JSRegExp re(heap_object);`
`731`	`731`	`return pre + Stringify(re, err);`
`732`	`732`	`}`