Skip to content

Commit c29d5af

Browse files
committed
test: disable flaky test for findrefs -s
PR-URL: #244 Refs: #115 Reviewed-By: Matheus Marchini <mat@mmarchini.me>
1 parent aad5414 commit c29d5af

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

test/plugin/scan-test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,14 @@ function test(executable, core, t) {
119119
sess.linesUntil(versionMark, (err, lines) => {
120120
t.error(err);
121121
t.ok(/Class_C\.arr/.test(lines.join('\n')), 'Should find parent reference with -r -n' );
122-
sess.send('v8 findrefs -s "My Class C"');
122+
// TODO(mmarchini) see comment below
123+
// sess.send('v8 findrefs -s "My Class C"');
124+
sess.send('v8 findjsinstances Zlib');
123125
sess.send('version');
124126
});
125127

128+
/* TODO(mmarchini) we need to fix
129+
* https://github.com/nodejs/llnode/issues/267 before re-enabling this test
126130
// Test for findrefs -s
127131
sess.linesUntil(versionMark, (err, lines) => {
128132
t.error(err);
@@ -138,6 +142,7 @@ function test(executable, core, t) {
138142
sess.send('v8 findjsinstances Zlib');
139143
sess.send('version');
140144
});
145+
*/
141146

142147
sess.linesUntil(versionMark, (err, lines) => {
143148
t.error(err);

0 commit comments

Comments
 (0)