Skip to content

Commit bd3a1c7

Browse files
committed
meta: add policy to land PRs without approval
As discussed in the 2020-02-12 Diagnostics WG Meeting and suggested in #242 (comment), change the landing policy so that Collaborators can land pull requests if it was open for three days and there were no reviews on it. Ref: nodejs/diagnostics#355 PR-URL: #336 Refs: nodejs/diagnostics#355 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent bff9f5e commit bd3a1c7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@ with the following differences:
99
- There's no minimum wait time for landing a pull request. Pull requests can
1010
land as soon as they get approved by at least one Collaborator.
1111
- Approval must be from Collaborators who are not authors of the change.
12+
- If the pull request was open for three days (72 hours) without reviews, and
13+
it was opened by a llnode Collaborator, the pull request can land without
14+
approvals.

0 commit comments

Comments
 (0)