test: use gdb to capture core on tests

mmarchini · mmarchini · commit 6f27d84f3f0d · 2020-01-09T15:34:02.000-08:00
gdb let us save core dumps on Linux (similar to what we do on OS X). For some reason, GitHub Actions are not generating system core dumps, so this is a good alternative to keep tests working when we move. PR-URL: #323 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
diff --git a/test/common.js b/test/common.js
@@ -247,12 +247,14 @@ function spawnWithTimeout(cmd, cb) {
 }
 
 function saveCoreLinux(executable, scenario, core, cb) {
-  const cmd = `ulimit -c unlimited && ${executable} ` +
-              `--abort_on_uncaught_exception --expose_externalize_string ` +
-              `${path.join(exports.fixturesDir, scenario)}; `;
+  // TODO(mmarchini): Let users choose if they want system generated core dumps
+  // or gdb generated core dumps.
+  const cmd = `gdb ${executable} --batch -ex 'run ` +
+    `--abort-on-uncaught-exception --expose-externalize-string ` +
+    `${path.join(exports.fixturesDir, scenario)}' -ex 'generate-core-file ` +
+    `${core}'`;
   spawnWithTimeout(cmd, () => {
-    // FIXME (mmarchini): Should also handle different core system settings.
-    spawnWithTimeout(`mv ./core ${core}`, cb);
+    cb()
   });
 }
 
