Skip to content

Commit 2c4c99c

Browse files
committed
src: use new SystemPointerSize constant
This alone should fix a lot of issues. It was enough to get a reasonable stack trace from a Node.js v12.3.0 core dump, ran with --interpreted-frames-native-stack. For some reason `v8 bt` is not working when running Node.js in lldb. PR-URL: #300 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent fb25c91 commit 2c4c99c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/llv8-constants.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ void Module::Assign(SBTarget target, Common* common) {
3030

3131

3232
void Common::Load() {
33-
kPointerSize = 1 << LoadConstant("PointerSizeLog2");
33+
kPointerSize = 1 << LoadConstant("PointerSizeLog2", "SystemPointerSizeLog2");
3434
kVersionMajor = LoadRawConstant("v8::internal::Version::major_");
3535
kVersionMinor = LoadRawConstant("v8::internal::Version::minor_");
3636
kVersionPatch = LoadRawConstant("v8::internal::Version::patch_");

0 commit comments

Comments
 (0)