corrections to Makefile and CMakeLists.txt for correct releases#170
Merged
mcollina merged 1 commit intonodejs:mainfrom Jul 30, 2022
Merged
corrections to Makefile and CMakeLists.txt for correct releases#170mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
1. replace previous "VERSION 6.0.5" by "VERSION _TAG_" in CMakelists.txt
2. e.g. "TAG=6.0.7 make release" will now use sed to replace _TAG_ by 6.0.7
in release/CMakeLists.txt
3. "make release" will also now include the new addition libllhttp.pc.in to
when updating the release branch.
Contributor
Author
|
Here are the fixes you requested for the release script. |
Contributor
Author
|
since you have already used tags 6.0.7 and 6.0.7a, I think you will need to repeat with TAG=6.0.7b e.g. |
mcollina
approved these changes
Jul 30, 2022
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm
thanks, I'll ship as soon as I can
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.