Skip to content

Validate POST payloads from Jenkins - #40

Merged
phillipj merged 1 commit into
masterfrom
validate-jenkins-payload
May 12, 2016
Merged

phillipj merged 1 commit into
masterfrom
validate-jenkins-payload

Conversation

@phillipj

Copy link
Copy Markdown
Member

So far there's been cases when sha, or other required fields of the payload has been missing, but the bot has willingly tried to proxy it as well as responding with a misleading 201 status code.

This at least does some trivial validation and tells you right away if the payload is seen invalid.

@Fishrock123

Copy link
Copy Markdown
Contributor

lgtm if tests pass

@phillipj

Copy link
Copy Markdown
Member Author

lgtm if tests pass

Travis says so 😸

@phillipj
phillipj merged commit 9c72402 into master May 12, 2016
@phillipj
phillipj deleted the validate-jenkins-payload branch May 12, 2016 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants