Skip to content

move sse code to github-events - #28

Merged
williamkapke merged 2 commits into
nodejs:masterfrom
williamkapke:move-sse-code
Apr 15, 2016
Merged

williamkapke merged 2 commits into
nodejs:masterfrom
williamkapke:move-sse-code

Conversation

@williamkapke

Copy link
Copy Markdown
Contributor

Having the events emitting in 2 places is not good. The SSE relay is only github-events related code - so it makes sense to move it to the github-events.js file.

Also, I am now emitting the org, repo, and sender names since will be needed by most listeners.

@Fishrock123

Copy link
Copy Markdown
Contributor

seems good to me

@williamkapke
williamkapke merged commit a5e4799 into nodejs:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants