Skip to content

trigger-jenkins-build: DRY up event handlers #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maclover7 merged 1 commit into from
Jul 28, 2018
Merged

trigger-jenkins-build: DRY up event handlers #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 26 additions & 40 deletions scripts/trigger-jenkins-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,33 +98,36 @@ function createPrComment ({ owner, repo, number, logger }, body) {
})
}

module.exports = (app) => {
app.on('issue_comment.created', function handleCommentCreated (event, owner, repo) {
const { number, logger, comment } = event
const commentAuthor = comment.user.login
const options = {
owner,
repo,
number,
logger
function triggerBuildIfValid (options) {
const { owner, repo, author, logger } = options

githubClient.repos.checkCollaborator({ owner, repo, username: author }, function onResponse (err) {
if (err) {
return logger.debug(`Ignoring comment to me by @${options.author} because they are not a repo collaborator`)
}

function replyToCollabWithBuildStarted (err, buildUrl) {
triggerBuild(options, function onBuildTriggered (err, buildUrl) {
if (err) {
logger.error(err, 'Error while triggering Jenkins build')
return createPrComment(options, `@${commentAuthor} sadly an error occured when I tried to trigger a build :(`)
return createPrComment(options, `@${options.author} sadly an error occured when I tried to trigger a build :(`)
}

createPrComment(options, `@${commentAuthor} build started: ${buildUrl}`)
createPrComment(options, `@${options.author} build started: ${buildUrl}`)
logger.info({ buildUrl }, 'Jenkins build started')
}

function triggerBuildWhenCollaborator (err) {
if (err) {
return logger.debug(`Ignoring comment to me by @${commentAuthor} because they are not a repo collaborator`)
}
})
})
}

triggerBuild(options, replyToCollabWithBuildStarted)
module.exports = (app) => {
app.on('issue_comment.created', function handleCommentCreated (event, owner, repo) {
const { number, logger, comment } = event
const commentAuthor = comment.user.login
const options = {
owner,
repo,
number,
logger,
author: commentAuthor
}

ifBotWasMentionedInCiComment(comment.body, (err, wasMentioned) => {
Expand All @@ -134,7 +137,7 @@ module.exports = (app) => {

if (!wasMentioned) return

githubClient.repos.checkCollaborator({ owner, repo, username: commentAuthor }, triggerBuildWhenCollaborator)
triggerBuildIfValid(options)
})
})

Expand All @@ -145,29 +148,12 @@ module.exports = (app) => {
owner,
repo,
number,
logger
}

function replyToCollabWithBuildStarted (err, buildUrl) {
if (err) {
logger.error(err, 'Error while triggering Jenkins build')
return createPrComment(options, `@${pullRequestAuthor} sadly an error occured when I tried to trigger a build :(`)
}

createPrComment(options, `@${pullRequestAuthor} build started: ${buildUrl}`)
logger.info({ buildUrl }, 'Jenkins build started')
}

function triggerBuildWhenCollaborator (err) {
if (err) {
return logger.debug(`Ignoring comment to me by @${pullRequestAuthor} because they are not a repo collaborator`)
}

triggerBuild(options, replyToCollabWithBuildStarted)
logger,
author: pullRequestAuthor
}

if (repo === 'node') {
githubClient.repos.checkCollaborator({ owner, repo, username: pullRequestAuthor }, triggerBuildWhenCollaborator)
triggerBuildIfValid(options)
}
})
}