Skip to content

trigger-jenkins-build: DRY up event handlers - #191

Merged
maclover7 merged 1 commit into
nodejs:masterfrom
maclover7:jm-dry-jenkins
Jul 28, 2018
Merged

maclover7 merged 1 commit into
nodejs:masterfrom
maclover7:jm-dry-jenkins

Conversation

@maclover7

Copy link
Copy Markdown
Contributor

@phillipj

Copy link
Copy Markdown
Member

I feel like I lack some context to review this.. What's the motivation and rationale behind these changes?

@maclover7

Copy link
Copy Markdown
Contributor Author

@phillipj It's to reduce duplication between the two event handlers. They're basically the same, besides for what variable they use for the "author" of the event

phillipj

This comment was marked as off-topic.

@maclover7
maclover7 merged commit 8fa4cff into nodejs:master Jul 28, 2018
@maclover7
maclover7 deleted the jm-dry-jenkins branch July 28, 2018 03:34
@maclover7

Copy link
Copy Markdown
Contributor Author

Landed in 8fa4cff, thank you for the review @phillipj! (no worries about timing :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants