node-repo: fix getBotPrLabels #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error occurring in production, likely happening due
to the recent bump in dependencies.
```
10:49:01.780 FATAL bot: Unchaught exception, terminating bot process immediately
TypeError: events[Symbol.iterator] is not a function
at githubClient.issues.getEvents (/home/iojs/github-bot/lib/node-repo.js:163:23)
at /home/iojs/github-bot/node_modules/github/lib/index.js:912:9
at callCallback (/home/iojs/github-bot/node_modules/github/lib/index.js:738:9)
at IncomingMessage.<anonymous> (/home/iojs/github-bot/node_modules/github/lib/index.js:810:13)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:978:12)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
```
Refs: #188
Contributor
Author
|
cc @Trott |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
Thanks for noticing the error and fixing it. And hooray for more test coverage! |
Contributor
Author
|
Going to go ahead and land this now, to fix the production server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error occurring in production, likely happening due
to the recent bump in dependencies.
Refs: #188