update github package to 12.x #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nit in commit message: 12.x |
This eliminates a "high' (risk? priority? something else?) warning that comes up with `npm audit`. There are still other deps that need updating but this is probably the big one and doing it as incrementally as possible while still eliminating that red "high" warning.
Member
Author
|
@targos Whoops, thanks! Fixed in the commit message and also in the PR title. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
/ping @nodejs/github-bot |
Contributor
|
Will merge/deploy early this week if no one else gets to it |
Contributor
|
Merged + deployed |
maclover7
added a commit
that referenced
this pull request
Jul 19, 2018
Fixes the following error occurring in production, likely happening due
to the recent bump in dependencies.
```
10:49:01.780 FATAL bot: Unchaught exception, terminating bot process immediately
TypeError: events[Symbol.iterator] is not a function
at githubClient.issues.getEvents (/home/iojs/github-bot/lib/node-repo.js:163:23)
at /home/iojs/github-bot/node_modules/github/lib/index.js:912:9
at callCallback (/home/iojs/github-bot/node_modules/github/lib/index.js:738:9)
at IncomingMessage.<anonymous> (/home/iojs/github-bot/node_modules/github/lib/index.js:810:13)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:978:12)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
```
PR-URL: #190
Refs: #188
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates a "high' (risk? priority? something else?) warning that
comes up with
npm audit. There are still other deps that need updatingbut this is probably the big one and doing it as incrementally as
possible while still eliminating that red "high" warning.