🎉 Delete Travis polling code in favor of Travis CI GitHub app 🎉 #183
Conversation
phillipj
changed the title
|
@Trott how did you install the GitHub app for i18n? I've tried digging into this repo and nodejs.org's Settings, but haven't found the list of GitHub apps to install 🤷♀️ |
|
@phillipj AFAIK it's something that only org owners can do. I can activate the app for all the repos that you listed above. |
|
@phillipj done! |
|
@targos awesome, much appreciated! That means this is ready to be merged as soon as someone had a look at the changes. /cc @nodejs/github-bot |
phillipj
force-pushed
the
remove-travis-polling
branch
from
890cd7c to
a1278c7
Compare
|
@targos I tried amending and force pushing to this branch and expected Travis to kick off, but it didn't :/ You got any thoughts? I see Travis CI is listed on services, not GitHub apps or do I interpret that UI wrong?
|
|
@phillipj The GitHub App is configured through the organization setting instead of the repo setting. I see that @targos has granted access to the repos listed in the OP. I think @Trott tried to see if Travis can be kicked off automatically after the app is installed but we could not find anything in the Travis UI at that time either. Have you managed to find a successful CI run triggered by the app? @Trott |
|
So, I experimented with the https://github.com/TestOrgPleaseIgnore/test-travis-app repo:
|
|
I noticed there is a difference in the repo's app setting page |
|
There seems to be an issue with this specific repo. Here is the nodejs dashboard on https://travis-ci.com/nodejs:
|
|
Oh, I think this repo has not been added to the list of repo that Travis has access to. I have added it now.
|
|
@phillipj Can you try force pushing again? |
|
Ah lol, this repo wasn't listed in the OP so I didn't add it :) |
|
Can we delete the service now? |
phillipj
force-pushed
the
remove-travis-polling
branch
from
a1278c7 to
676c5c3
Compare
Ohhh 🤦♂️ Sorry for the confusion, I haven't practised my telepathy sense in a while! Still no signs of life after force pushing again. I'll try and delete the service like @targos mention, to see if that has anything to do with it. |
phillipj
force-pushed
the
remove-travis-polling
branch
from
676c5c3 to
2d4c287
Compare
|
Nehhh still nothing I'm afraid :/ Just in case this is an issue on this particular repo, do any of you have other repos you can verify that replacing the service (and therefore the github-bot) with the Travis CI GitHub app works as expected? |
|
I think this is the problem:
The GitHub app works only on travis-ci.com. Because this repo was already using travis-ci.org and hasn't been migrated yet, it doesn't work. |
So I guess we can only wait until then..? |
|
Found this while clicking through Travis CI docs:
I'd personally say its more beneficial for us to migrate ASAP rather than waiting in hopes the Travis crew fixes migration of history and settings. If more of you agree, we might consider sending a list of repo names to the email above? |
|
With three thumbs up on my previous comment, I'm sending Travis an email to hear if they can help us out. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Confirmed we wanted the entire list of repos in OP to be migrated. |
|
That did the trick, Travis CI is now working with the GitHub app in place. Much appreciated @non-binary! |
We have recently found that we can enable Travis CI per repo with the Travis CI GitHub app, rather than the old GitHub Service that required organization wide private access, which the nodejs organization didn't want to provide. Since using the GitHub app per repo instead, there is no need for this bot to do any Travis CI polling anymore -- hoooray!
Primarily as a test to hopefully trigger the newly added Travis CI GitHub app.
phillipj
force-pushed
the
remove-travis-polling
branch
from
583a012 to
e8d7f8c
Compare
|
Seeing that the Travis CI app also works as expected in another repo (nodejs/node-core-utils#255) it looks like we're ready to land this PR to stop the github-bot from posting the same Travis updates to PRs. |
|
@phillipj We should delete the web hooks first otherwise there will be a bunch of 404's in the hooks |
|
@joyeecheung good point 👍 This is where we need to delete the webhook against
P.S. I've already deleted a couple of webhook where I had permissions to do so. |
|
Should we ask the owners first in case there are any special settings in their hooks? |
|
I deleted the hooks of node-core-utils, llnode and core-validate-commit because I know they are not going to need it |
|
cc @rvagg @zeke @PeterDaveHello @MylesBorins @mcollina regarding deleting the webhooks of the github bot in favor of github apps, see #183 (comment) |
|
Good for me, I’m on vacation until the 24th. Feel free to do it for readable-stream, or I’ll do it when I get back. |
|
lgtm! make it happen, great news! |
|
|
|
@chorrell I removed the old integration |
|
I went ahead and deleted all the remaining webhooks and service integrations. If any project comes back needing those we can always revert, but I doubt if that's necessary. This PR should be safe to merge now. |
|
@non-binary this change did mess up our secured var for the github bot access token here: https://github.com/nodejs/docker-node/blob/master/.travis.yml#L79 would it be possible to add that token to Travis.com UI instead of having it here? |
|
I woukd change it but I do not have the token for the bot. |
|
@non-binary we are using the Node Bot and if I remember correctly, the same token is used everywhere |
|
Last time @rvagg provided the encrypted token |
|
Can someone who has access to the token add it to the docker-node repo Travis config? |
|
@LaurentGoderre could you verify I encrypted this correctly? |
|
Thanks all for reviews and help changing the repo settings! I'm merging this now, any new issues discovered can should probably get their own issues in this repo or whichever repo it relates to. |
8 participants
We have recently found that we can enable Travis CI per repo with the Travis CI GitHub app, rather than the old GitHub Service that required organization wide private access, which the nodejs organization didn't want to provide.
Since using the GitHub app per repo instead, there is no need for this bot to do any Travis CI polling anymore -- hoooray!
Before merging this we have to enable install the Travis CI app on these repos: