Jenkins: ignore ended builds not related to pull requests #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an improvement of a recent attemt to ignore any Jenkins build
status updates that was *not* related to pull requests.
While looking at the logs after the last fix was merged, it surprised
me that we still got those kinds of errors popping up:
```
22:24:02.994 ERROR bot: Got error when retrieving GitHub commits for PR (req_id=3741a210-6cec-11e8-a3a3-e194f9df710c, pr=master, job=node-test-commit-plinux, status=success)
err: {
"code": "400",
"status": "Bad Request",
"message": "Invalid value for parameter 'number': master"
}
```
Looking closely on the info included in that error log, made it clear it
could be an issue on builds that had *ended*. Digging into the fix
that was recently pushed, I discovered that fix only applied to for statuses
Jenkins pushes to the bot when it *starts* builds.
Applying the previous fix to the bot endpoint that handles *ended* Jenkins
builds as well, should make these error logs disappear.
Refs nodejs#177
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement of a recent attemt to ignore any Jenkins build status updates that was not related to pull requests.
While looking at the logs after the last fix was merged, it surprised me that we still got those kinds of errors popping up:
Looking closely on the info included in that error log, made it clear it could be an issue on builds that had ended. Digging into the fix that was recently pushed, I discovered that fix only applied to for statuses Jenkins pushes to the bot when it starts builds.
Applying the previous fix to the bot endpoint that handles ended Jenkins builds as well, should make these error logs disappear.
Refs #177
/cc @nodejs/github-bot