Skip to content

Stop logging all finished requests to reduce log noise #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phillipj merged 1 commit into from
Jun 9, 2018
Merged

Stop logging all finished requests to reduce log noise #176

phillipj merged 1 commit into from
Jun 9, 2018

Conversation

@phillipj
Copy link
Member

@phillipj phillipj commented Jun 9, 2018

Thought I'd do a rounds of much needed cleanup on this bot, starting with the logs.

So far we have been logging absolutely all finished requests which results in a lot of noise in logs.

Local example:

$ npm start

..

12:13:32.529Z  INFO bot: Listening on port 3000
12:13:34.468Z  INFO bot: request finish (req_id=8812b800-6bde-11e8-add8-f393315a261f, duration=3.191551, req.query={}, req.remoteAddress=::1, req.remotePort=63894)
    GET /ping HTTP/1.1
    host: localhost:3000
    user-agent: curl/7.54.0
    accept: */*
    --
    HTTP/1.1 200 OK
    X-Powered-By: Express
    X-Request-Id: 8812b800-6bde-11e8-add8-f393315a261f
    Date: Sat, 09 Jun 2018 12:13:34 GMT
    Connection: keep-alive
    Content-Length: 4

Personally cannot remember once where this request information has actually been valuable. If it turns out I'm wrong, we could easily enable this again if needed for debugging purposes.

/cc @nodejs/github-bot

@phillipj
fix(logs): stop logging all finished requests to reduce log noise
cc71c08 
So far we have been logging absolutely *all* finished requests which
results in a lot of noise in logs.
phillipj

This comment was marked as off-topic.

Sign in to view

maclover7

This comment was marked as off-topic.

Sign in to view

@phillipj phillipj merged commit 828e197 into nodejs:master Jun 9, 2018
@phillipj phillipj deleted the stop-logging-request-finish branch June 9, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maclover7 maclover7 maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phillipj @maclover7