Skip to content

labels: map dont-land-on-v4(6).x for http2 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phillipj merged 3 commits into from
Oct 7, 2017
Merged

labels: map dont-land-on-v4(6).x for http2 #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
057d917
labels: map dont-land-on-v4(6).x for http2
MylesBorins Sep 20, 2017
3a8fbc3
labels: added tests for map dont-land-on-v4(6).x for http2
phillipj Oct 7, 2017
2a537b8
labels: map dont-land-on-v4(6).x for lib/http2
phillipj Oct 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/node-labels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const subSystemLabelsMap = new Map([
[/^src\/node_zlib/, ['c++', 'zlib']],
[/^src\/tracing/, ['c++', 'tracing']],
[/^src\/node_api/, ['c++', 'n-api', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
[/^src\/node_http2/, ['c++', 'http2']],
[/^src\/node_http2/, ['c++', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],

// don't label python files as c++
[/^src\/.+\.py$/, 'lib / src'],
Expand Down Expand Up @@ -73,8 +73,8 @@ const subSystemLabelsMap = new Map([
[/^deps\/uv\//, 'libuv'],
[/^deps\/v8\/tools\/gen-postmortem-metadata\.py/, ['V8 Engine', 'post-mortem']],
[/^deps\/v8\//, 'V8 Engine'],
[/^deps\/nghttp2\/nghttp2\.gyp/, ['build', 'http2']],
[/^deps\/nghttp2\//, 'http2'],
[/^deps\/nghttp2\/nghttp2\.gyp/, ['build', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
[/^deps\/nghttp2\//, ['http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
[/^deps\/([^/]+)/, '$1'],

/* JS subsystems */
Expand All @@ -87,6 +87,7 @@ const subSystemLabelsMap = new Map([
[/^lib\/\w+\/v8_prof_/, 'tools'],
[/^lib\/\w+\/socket_list/, 'net'],
[/^lib\/\w+\/streams$/, 'stream'],
[/^lib\/.*http2/, ['http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x']],
[/^lib\/internal\/url\.js$/, ['url-whatwg',
'dont-land-on-v4.x', 'dont-land-on-v6.x']],
// All other lib/ files map directly
Expand Down
7 changes: 4 additions & 3 deletions test/unit/node-labels.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,16 +615,17 @@ tap.test('label: "build" when ./android-configure has been changed', (t) => {
});

[
[ ['http2'],
[ ['http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
['lib/http2.js',
'lib/internal/http2/core.js',
'deps/nghttp2/lib/nghttp2_buf.c'] ],
[ ['c++', 'http2'],
[ ['c++', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
['src/node_http2.cc',
'src/node_http2.h',
'src/node_http2_core.h',
'src/node_http2_core-inl.h'] ],
[ ['build', 'http2'], ['deps/nghttp2/nghttp2.gyp'] ],
[ ['build', 'http2', 'dont-land-on-v4.x', 'dont-land-on-v6.x'],
['deps/nghttp2/nghttp2.gyp'] ],
[ ['doc', 'http2'], ['doc/api/http2.md'] ]
].forEach((info) => {
const labels = info[0]
Expand Down