Skip to content

Conversation

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Sep 20, 2017

http2 does not exist in these branches

@phillipj
Copy link
Member

Looks like there's 5 failing tests here 😮

npm test output
test/integration/node-labels-webhook.test.js .......... 4/4 2s
test/integration/ping.test.js ......................... 3/3
test/integration/push-jenkins-update.test.js .......... 6/6
test/unit/node-build-label.test.js .................. 14/14
test/unit/node-js-subsystem-labels.test.js ............ 8/8
test/unit/node-labels.test.js ..................... 172/177
  label: "c++","http2" when ./src/node_http2.cc has been changed
  not ok should be equivalent
    +++ found
    --- wanted
     [
       "c++"
       "http2"
    +  "dont-land-on-v4.x"
    +  "dont-land-on-v6.x"
     ]
    at:
      line: 636
      column: 9
      file: test/unit/node-labels.test.js
      type: Test
      function: tap.test
    stack: |
      Test.tap.test (test/unit/node-labels.test.js:636:9)
      __dirname.forEach (test/unit/node-labels.test.js:633:9)
      Array.forEach (native)
      Object.<anonymous> (test/unit/node-labels.test.js:629:3)
    source: |
      t.same(resolved, labels)

  label: "c++","http2" when ./src/node_http2.h has been changed
  not ok should be equivalent
    +++ found
    --- wanted
     [
       "c++"
       "http2"
    +  "dont-land-on-v4.x"
    +  "dont-land-on-v6.x"
     ]
    at:
      line: 636
      column: 9
      file: test/unit/node-labels.test.js
      type: Test
      function: tap.test
    stack: |
      Test.tap.test (test/unit/node-labels.test.js:636:9)
      __dirname.forEach (test/unit/node-labels.test.js:633:9)
      Array.forEach (native)
      Object.<anonymous> (test/unit/node-labels.test.js:629:3)
    source: |
      t.same(resolved, labels)

  label: "c++","http2" when ./src/node_http2_core.h has been changed
  not ok should be equivalent
    +++ found
    --- wanted
     [
       "c++"
       "http2"
    +  "dont-land-on-v4.x"
    +  "dont-land-on-v6.x"
     ]
    at:
      line: 636
      column: 9
      file: test/unit/node-labels.test.js
      type: Test
      function: tap.test
    stack: |
      Test.tap.test (test/unit/node-labels.test.js:636:9)
      __dirname.forEach (test/unit/node-labels.test.js:633:9)
      Array.forEach (native)
      Object.<anonymous> (test/unit/node-labels.test.js:629:3)
    source: |
      t.same(resolved, labels)

  label: "c++","http2" when ./src/node_http2_core-inl.h has been changed
  not ok should be equivalent
    +++ found
    --- wanted
     [
       "c++"
       "http2"
    +  "dont-land-on-v4.x"
    +  "dont-land-on-v6.x"
     ]
    at:
      line: 636
      column: 9
      file: test/unit/node-labels.test.js
      type: Test
      function: tap.test
    stack: |
      Test.tap.test (test/unit/node-labels.test.js:636:9)
      __dirname.forEach (test/unit/node-labels.test.js:633:9)
      Array.forEach (native)
      Object.<anonymous> (test/unit/node-labels.test.js:629:3)
    source: |
      t.same(resolved, labels)

  label: "build","http2" when ./deps/nghttp2/nghttp2.gyp has been changed
  not ok should be equivalent
    +++ found
    --- wanted
     [
       "build"
       "http2"
    +  "dont-land-on-v4.x"
    +  "dont-land-on-v6.x"
     ]
    at:
      line: 636
      column: 9
      file: test/unit/node-labels.test.js
      type: Test
      function: tap.test
    stack: |
      Test.tap.test (test/unit/node-labels.test.js:636:9)
      __dirname.forEach (test/unit/node-labels.test.js:633:9)
      Array.forEach (native)
      Object.<anonymous> (test/unit/node-labels.test.js:629:3)
    source: |
      t.same(resolved, labels)

test/unit/node-repo.test.js ........................... 7/7
total ............................................. 214/219


  214 passing (5s)
  5 failing

@phillipj
Copy link
Member

phillipj commented Oct 7, 2017

Took the liberty of pushing a couple of commits to your branch containing tests and mapping ./lib/http2.js | ./lib/internal/http2/core.js as well.

Thanks a bunch for this PR 👍

gibfahn

This comment was marked as off-topic.

@phillipj phillipj merged commit 964ee98 into nodejs:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants