You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noting it here so this isn't forgotten about (currently broken on the production server). I believe this is another issue caused by the recent github version bump (something something need better test coverage). At least the labels resolved correctly?
(By the way, I think one or two of the relevant package's maintainers is on the project. @zeke for sure and I think Gregor used to be but maybe not anymore?)
The github package is deprecated as of version 13-ish as I recall. The module has been renamed to @octokit/rest and is being heroically maintained by @gr2m.
@zeke Thanks! Unfortunately, swapping out the dependency without making other changes currently breaks everything. But it might be worth looking at more closely to see how much work would be involved in fixing stuff. (It's midnight here and I'm going to bed after finishing this comment, though, so it will have to wait...) That said, a little bit of context:
We just recently updated from the github package version 7.x to 12.x to eliminate a warning from npm audit. My goal/hope was to let this bake, fix bugs like this that are reported, write some more tests, and then upgrade to the current thing when there is slightly more test coverage.
Before going that route, I tried to upgrade to @octokit/rest but it broke a lot more code. I took a quick look at fixing it, but decided an incremental update approach would be better, especially given our modest test coverage. That might or might not have been the wrong decision, but it seemed like the thing to do at the time.
(You're under no obligation to help out here, of course. Just looped you in in case it was of interest or if the current issue was something you knew the fix for offhand. That said, any and all assistance is welcome!)
Chiming in here to add some thoughts.. A while back I also tried to upgrade to @octokit/rest which causes havoc for the integration tests if I remember correctly.
I tried to wrestle those tests for some hours, and got very close, but couldn't get the last couple of tests to pass. To me it smelled like some async timing issues. For some reason I weren't able to get nock to respond currently / in time for the tests to pass.
Thinking out loud, we might need to refactor our integration tests slightly, or possibly even replace nock if someone has better alternatives? 🤷♂️
Activity
Trott commentedon Jul 20, 2018
@maclover7 I think this change will fix it. Any chance you can easily test?
Trott commentedon Jul 20, 2018
(By the way, I think one or two of the relevant package's maintainers is on the project. @zeke for sure and I think Gregor used to be but maybe not anymore?)
zeke commentedon Jul 21, 2018
The
githubpackage is deprecated as of version 13-ish as I recall. The module has been renamed to@octokit/restand is being heroically maintained by @gr2m.As a first step, I would suggest swapping out the dependency in https://github.com/nodejs/github-bot/blob/master/lib/github-client.js and seeing if that fixes it.
Trott commentedon Jul 21, 2018
@zeke Thanks! Unfortunately, swapping out the dependency without making other changes currently breaks everything. But it might be worth looking at more closely to see how much work would be involved in fixing stuff. (It's midnight here and I'm going to bed after finishing this comment, though, so it will have to wait...) That said, a little bit of context:
We just recently updated from the
githubpackage version 7.x to 12.x to eliminate a warning fromnpm audit. My goal/hope was to let this bake, fix bugs like this that are reported, write some more tests, and then upgrade to the current thing when there is slightly more test coverage.Before going that route, I tried to upgrade to
@octokit/restbut it broke a lot more code. I took a quick look at fixing it, but decided an incremental update approach would be better, especially given our modest test coverage. That might or might not have been the wrong decision, but it seemed like the thing to do at the time.(You're under no obligation to help out here, of course. Just looped you in in case it was of interest or if the current issue was something you knew the fix for offhand. That said, any and all assistance is welcome!)
maclover7 commentedon Jul 22, 2018
Sadly not without editing code manually on the server. I'll open up a PR, and will merge/deploy if you approve it.
node-repo: switch option name
maclover7 commentedon Jul 23, 2018
Looks like this has been solved, closing for now:
phillipj commentedon Jul 27, 2018
Chiming in here to add some thoughts.. A while back I also tried to upgrade to
@octokit/restwhich causes havoc for the integration tests if I remember correctly.I tried to wrestle those tests for some hours, and got very close, but couldn't get the last couple of tests to pass. To me it smelled like some async timing issues. For some reason I weren't able to get nock to respond currently / in time for the tests to pass.
Thinking out loud, we might need to refactor our integration tests slightly, or possibly even replace nock if someone has better alternatives? 🤷♂️