-
Notifications
You must be signed in to change notification settings - Fork 2k
Replaced the new Travis token #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@phillipj it doesn't seem to work. Did you encrypt it for this repo? |
|
I was convinced so, yes.. Haven't encrypted secrets like these for Travis before though, so I wouldn't be surprised if I'm doing something wrong. Any thoughts? |
|
Does it require me to have collaborator status in this repo? |
|
@phillipj I personally prefer to have it here: https://travis-ci.com/nodejs/docker-node/settings |
|
It's worth noting that if you add it, none of us will see it, the only way to change it is deleting it and re-adding it, which I think makes a lot of sense for security. |
|
By looking at the repositories listed under "My repositories" on travis-ci.com, it might look like I have to be a collaborator to be able to change Travis CI settings on a repo. docker-node is currently not in that list, and I don't see an Settings-option under "More options" on travis-ci.com/nodejs/docker-node. We can either test giving me temporary collaborator status here or we'd have to summon someone else, probably an org admin. @LaurentGoderre are you able/want to do the former? |
|
@phillipj try it now! |
|
@LaurentGoderre thanks, that did the trick! I re-created it now, could you give it at try? If that also fails, I could even create a new token just to try everything.. |
|
I take it the environment variable I created on travis-ci.com worked, feel free to remove my collaborator status from this repo. |
No description provided.