Skip to content

feat: upgrade node to 14.13.1 - #1359

Merged
nschonni merged 1 commit into
nodejs:masterfrom
ttshivers:14.13.1
Oct 8, 2020
Merged

nschonni merged 1 commit into
nodejs:masterfrom
ttshivers:14.13.1

Conversation

@ttshivers

Copy link
Copy Markdown
Member

@SimenB

SimenB commented Oct 8, 2020

Copy link
Copy Markdown
Member

Do we need any other changes to the actions for the auto PRs to work? Ref docker-library/official-images#8852 which is broken

@ttshivers

Copy link
Copy Markdown
Member Author

#1357 should probably be reviewed / merged so 14.13.0 gets a tag.

@SimenB

SimenB commented Oct 8, 2020

Copy link
Copy Markdown
Member

14.13 exists: https://hub.docker.com/_/node?tab=tags. Unless I'm misunderstanding what you mean by "tag"

@nschonni

nschonni commented Oct 8, 2020

Copy link
Copy Markdown
Member

@SimenB I think it's about the fact that the auto-official-images PR is still bugged, so if this lands, it won't trigger the tagging right now

@nschonni

nschonni commented Oct 8, 2020

Copy link
Copy Markdown
Member

Tracking the fixing of the PR pushing over here #1360

@nschonni

nschonni commented Oct 8, 2020

Copy link
Copy Markdown
Member

Not related to this change, but it seems like something is broken with the test-build.sh it's trying to execute on a v10 version https://github.com/nodejs/docker-node/pull/1359/checks?check_run_id=1223696883#step:4:4

@ttshivers

Copy link
Copy Markdown
Member Author

Not related to this change, but it seems like something is broken with the test-build.sh it's trying to execute on a v10 version https://github.com/nodejs/docker-node/pull/1359/checks?check_run_id=1223696883#step:4:4

Yeah I noticed that when I was writing the action testing thing. It runs through all versions even if you call it with a specific one.

@github-actions

github-actions Bot commented Oct 8, 2020

Copy link
Copy Markdown

Created PR on the official-images repo (docker-library/official-images#8852). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@ttshivers

Copy link
Copy Markdown
Member Author

I think it worked!

@ttshivers
ttshivers deleted the 14.13.1 branch October 13, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants