Skip to content

ci(pr): checkout base_ref - #1357

Merged
nschonni merged 1 commit into
nodejs:masterfrom
ttshivers:pr_sha
Oct 8, 2020
Merged

nschonni merged 1 commit into
nodejs:masterfrom
ttshivers:pr_sha

Conversation

@ttshivers

Copy link
Copy Markdown
Member

#1355 (comment)
Merge after #1355

@ttshivers

ttshivers commented Oct 7, 2020 •

Copy link
Copy Markdown
Member Author

This may not be what is wanted. What if the PR is behind master?

A valid solution might be to check out master every time instead?

@nschonni

nschonni commented Oct 7, 2020

Copy link
Copy Markdown
Member

I think checkout out the default branch head commit makes sense, and I thought that is what it was doing, unless there is a delay with the pull_request_trigger trigger

@ttshivers ttshivers changed the title ci(pr): use PR sha instead of ref ci(pr): checkout base_ref Oct 7, 2020
@ttshivers

Copy link
Copy Markdown
Member Author

@nschonni
nschonni merged commit b8aba8b into nodejs:master Oct 8, 2020
@nschonni

nschonni commented Oct 8, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants