Skip to content

refactor(architectures): sort and align - #1355

Merged
nschonni merged 1 commit into
nodejs:masterfrom
ttshivers:sort_arches
Oct 7, 2020
Merged

nschonni merged 1 commit into
nodejs:masterfrom
ttshivers:sort_arches

Conversation

@ttshivers

Copy link
Copy Markdown
Member

This exists mainly to trigger the official-pr action

Comment thread 10/architectures Resolved
@nschonni
nschonni merged commit 26914a8 into nodejs:master Oct 7, 2020
@ttshivers

ttshivers commented Oct 7, 2020 •

Copy link
Copy Markdown
Member Author

Looks like the head ref thing failed: https://github.com/nodejs/docker-node/runs/1218677695
It looks like it was trying to checkout out the ref from my fork which doesn't exist in the main repo.

/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=50 origin +refs/heads/sort_arches*:refs/remotes/origin/sort_arches* +refs/tags/sort_arches*:refs/tags/sort_arches*

@nschonni

nschonni commented Oct 7, 2020

Copy link
Copy Markdown
Member

No worries, it's too late for me to keep looking this now

@ttshivers

Copy link
Copy Markdown
Member Author

No worries, it's too late for me to keep looking this now

Same here. For tomorrow, one thing to look into is checking out master or the PR head sha:
https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit

@nschonni

nschonni commented Oct 7, 2020

Copy link
Copy Markdown
Member

For further testing tomorrow, it's easier to add the PR workflow file to the affected files list at the top

@ttshivers
ttshivers deleted the sort_arches branch October 13, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants