feat: upgrade node to 12.19.0 - #1348

@ttshivers do you want to try and rebase this one just to see if the Actions are running OK?

Done. If this works, then it might very well be an issue with the PR commits not having the action in them.

Just cancelled and will restart the 12-slim job since it looked stalled

Created PR on the official-images repo (docker-library/official-images#8852). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sorry, tried to retrigger the workflow since it looks like the upstream PR was missing the change. The extra comment was just a side effect

I'm trying to look into why its not updating the PR even with the retrigger. https://github.com/nodejs/docker-node/runs/1218568048?check_suite_focus=true

I think it's the checkout ref, it might need to explicitly grab the PR head https://github.community/t/github-actions-are-severely-limited-on-prs/18179/17

The action was grabbing the previous commit to the merge (base master branch before merge) https://github.com/nodejs/docker-node/runs/1218568048?check_suite_focus=true#step:2:379

Very good find. That makes sense.

Do you think its best to do a fix adding that explicit ref head? Or potentially changing the trigger to be on master push to fix the issue of non-rebased PRs not triggering the action?

I think just the ref is a good first fix