Repository navigation
New automated PR checking out wrong commit #1360
Description
Opening an issue to track this, since the discussion is spread around various PRs that are trying to fix this.
/cc @ttshivers
Opening an issue to track this, since the discussion is spread around various PRs that are trying to fix this.
/cc @ttshivers
Activity
nschonni commentedon Oct 8, 2020
Looks like the upstream issue actions/checkout#299
@ttshivers was this one of the ones you tried already? actions/checkout#299 (comment)
nschonni commentedon Oct 8, 2020
Just tracking the issues and previous attempts that have disucssions spread across them:
ref: ${{ github.event.pull_request.head.ref }}ci(pr): fix auto-pr using non-current commit #1354. Brokenref: ${{ github.base_ref }}ci(pr): checkout base_ref #1357Think the next thing to try is
ref: ${{ github.event.pull_request.head.sha }}from the actions/checkout issuettshivers commentedon Oct 8, 2020
It appears that the actions lag behind. If you change the action in a PR and then merge it, the old action gets run.
The last merge successfully updated the official-images PR but did not run the new context dump.
nschonni commentedon Oct 8, 2020
I can't tell if it's using the right commit or not https://github.com/nodejs/docker-node/actions?query=workflow%3A%22Create+official+images+PR%22
Can you rebase the 14.13.1 PR so we can test to see if it affects beyond the action file?
nschonni commentedon Oct 23, 2020
Closing as I think we worked this out with some trial and error due to the nature of
pull_request_triggerbeing on PR behind for changes to that file